On Tue, Nov 01, 2011 at 05:20:25PM -0200, Eduardo Habkost wrote:
> This is what qemu_fclose() expects.
>
> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
> ---
> savevm.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index 3c746a6..63dd719 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -233,8 +233,9 @@ static int stdio_get_buffer(void *opaque, uint8_t *buf,
> int64_t pos, int size)
> static int stdio_pclose(void *opaque)
> {
> QEMUFileStdio *s = opaque;
> - int ret;
> - ret = pclose(s->stdio_file);
> + int ret = 0;
> + if (pclose(s->stdio_file) == -1)
> + ret = -errno;
> g_free(s);
> return ret;
Self-NACK. We have to return the pclose() return value here, because
exec_close() needs it.
Thanks to Paolo for spotting it.
--
Eduardo
