On 11/01/2011 08:08 PM, Anthony Liguori wrote: > On 10/30/2011 09:02 AM, Avi Kivity wrote: >> This somewhat controversial patchset converts internal arithmetic in the >> memory API to 128 bits. >> >> It has been argued that with careful coding we can make 64-bit work as >> well. I don't think this is true in general - a memory router can >> adjust >> addresses either forwards or backwards, and some buses (PCIe) need the >> full 64-bit space - though it's probably the case for all the >> configurations >> we support today. Regardless, the need for careful coding means >> subtle bugs, >> which I don't want in a core API that is driven by guest supplied >> values. >> >> Avi Kivity (3): >> Add support for 128-bit arithmetic >> memory: use 128-bit integers for sizes and intermediates >> Adjust system and pci address spaces to full 64-bit > > I now notice that this is not a PULL request... Did you mess up the > subject or the pull request? >
I forgot to supply the pull info, which is: git://github.com/avikivity/qemu.git memory/int128 -- error compiling committee.c: too many arguments to function
