On Tue, Oct 26, 2021 at 6:10 AM Hanna Reitz <hre...@redhat.com> wrote:
> On 19.10.21 16:49, John Snow wrote: > > Instead of using a process return code as the python function return > > value (or just not returning anything at all), allow run_linter() to > > raise an exception instead. > > > > The responsibility for printing output on error shifts from the function > > itself to the caller, who will know best how to present/format that > > information. (Also, "suppress_output" is now a lot more accurate of a > > parameter name.) > > > > Signed-off-by: John Snow <js...@redhat.com> > > --- > > tests/qemu-iotests/297 | 24 ++++++++++++++---------- > > 1 file changed, 14 insertions(+), 10 deletions(-) > > Thanks! :) > > Reviewed-by: Hanna Reitz <hre...@redhat.com> > > No problem. Thanks for taking the time to review it! --js
