On 10/23/21 4:14 PM, Michael S. Tsirkin wrote:
On Sat, Oct 23, 2021 at 07:52:21AM +0530, Ani Sinha wrote:
On Fri, 22 Oct 2021, Eric DeVolder wrote:
Ani, inline below.
eric
On 10/22/21 05:18, Ani Sinha wrote:
On Fri, 15 Oct 2021, Eric DeVolder wrote:
diff --git a/hw/i386/acpi-microvm.c b/hw/i386/acpi-microvm.c
I do not think we need to include this for microvm machines. They are
supposed to have minimal ACPUI support. So lets not bloat it unless there
is a specific requirement to support ERST on microvms as well.
Would it be ok if I ifdef this on CONFIG_ERST also?
I think we should not touch microvm machine unless you can justify why you
need ERST support there.
OTOH why not? No idea... CC microvm maintainers and let them decide.
I would argue that ERST support for microvm is in fact more useful than for
"regular" VMs: those VMs can use EFI storage for pstore while microvms won't
have that option.
-boris
