On [2021 Oct 04] Mon 17:46:33, Cédric Le Goater wrote: > The register index is currently printed and this is confusing. > > Signed-off-by: Cédric Le Goater <c...@kaod.org>
Reviewed-by: Francisco Iglesias <frasse.igles...@gmail.com> > --- > hw/ssi/aspeed_smc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c > index 7129341c129e..8a988c167604 100644 > --- a/hw/ssi/aspeed_smc.c > +++ b/hw/ssi/aspeed_smc.c > @@ -728,7 +728,7 @@ static uint64_t aspeed_smc_read(void *opaque, hwaddr > addr, unsigned int size) > addr < R_SEG_ADDR0 + asc->max_peripherals) || > (addr >= s->r_ctrl0 && addr < s->r_ctrl0 + asc->max_peripherals)) { > > - trace_aspeed_smc_read(addr, size, s->regs[addr]); > + trace_aspeed_smc_read(addr << 2, size, s->regs[addr]); > > return s->regs[addr]; > } else { > @@ -1029,10 +1029,10 @@ static void aspeed_smc_write(void *opaque, hwaddr > addr, uint64_t data, > AspeedSMCClass *asc = ASPEED_SMC_GET_CLASS(s); > uint32_t value = data; > > - addr >>= 2; > - > trace_aspeed_smc_write(addr, size, data); > > + addr >>= 2; > + > if (addr == s->r_conf || > (addr >= s->r_timings && > addr < s->r_timings + asc->nregs_timings) || > -- > 2.31.1 > >