Daniel P. Berrangé <berra...@redhat.com> writes:
> On Fri, Oct 01, 2021 at 07:08:51PM +0200, Paolo Bonzini wrote:
>> On 29/09/21 04:58, Yanan Wang wrote:
>> > @@ -933,8 +935,7 @@ static void machine_set_smp(Object *obj, Visitor *v,
>> > const char *name,
>> > return;
>> > }
>> > - smp_parse(ms, config, errp);
>> > - if (*errp) {
>> > + if (!smp_parse(ms, config, errp)) {
>> > qapi_free_SMPConfiguration(config);
>> > }
>> > }
>> >
>>
>> This is actually a leak, so I'm replacing this patch with
>
> This patch isn't adding a leak, as there's no change in
> control flow / exit paths. AFAICT, the leak was introduced
> in patch 15 instead, so the code below shoudl be squashed
> into that, and this patch left as-is.
Concur.
