On 9/29/21 01:29, Alistair Francis wrote: > From: Alistair Francis <alistair.fran...@wdc.com> > > Mark the shakti_c machine as not user creatable. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/639 > Signed-off-by: Alistair Francis <alistair.fran...@wdc.com> > --- > hw/riscv/shakti_c.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/riscv/shakti_c.c b/hw/riscv/shakti_c.c > index 2f084d3c8d..e7cd3bdfb4 100644 > --- a/hw/riscv/shakti_c.c > +++ b/hw/riscv/shakti_c.c > @@ -150,6 +150,12 @@ static void shakti_c_soc_class_init(ObjectClass *klass, > void *data) > { > DeviceClass *dc = DEVICE_CLASS(klass); > dc->realize = shakti_c_soc_state_realize; > + /* Reasons: > + * - Creates CPUS in riscv_hart_realize(), and can create unintended > + * CPUs
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> > + * - Uses serial_hds in realize function, thus can't be used twice > + */ > + dc->user_creatable = false; > }
