On Fri, Sep 24, 2021 at 5:59 AM Richard Henderson < richard.hender...@linaro.org> wrote:
> On 9/21/21 9:56 PM, Warner Losh wrote: > > From: Mikaël Urankar <mikael.uran...@gmail.com> > > > > Simmilar to the equivalent linux-user: commit fb7e378cf9c, which added > > checking to pread's return value. > > > > Signed-off-by: Mikaël Urankar <mikael.uran...@gmail.com> > > Signed-off-by: Warner Losh <i...@bsdimp.com> > > --- > > bsd-user/mmap.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > > - pread(fd, g2h_untagged(start), end - start, offset); > > + if (pread(fd, g2h_untagged(start), end - start, offset) == -1) > > + return -1; > > If it's not too annoying wrt rebasing other cleanups, please add the > braces now. > You bet. > > r~ >
