On 21.09.21 17:30, Peter Maydell wrote: > On Thu, 16 Sept 2021 at 16:54, Alexander Graf <ag...@csgraf.de> wrote: >> With Apple Silicon available to the masses, it's a good time to add support >> for driving its virtualization extensions from QEMU. >> >> This patch adds all necessary architecture specific code to get basic VMs >> working, including save/restore. >> >> Known limitations: >> >> - WFI handling is missing (follows in later patch) >> - No watchpoint/breakpoint support >> >> Signed-off-by: Alexander Graf <ag...@csgraf.de> >> Reviewed-by: Roman Bolshakov <r.bolsha...@yadro.com> >> Reviewed-by: Sergio Lopez <s...@redhat.com> >> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > This broke compilation on x86 osx: > >> --- a/target/i386/hvf/hvf.c >> +++ b/target/i386/hvf/hvf.c >> @@ -206,6 +206,11 @@ static inline bool apic_bus_freq_is_known(CPUX86State >> *env) >> return env->apic_bus_freq != 0; >> } >> >> +void hvf_kick_vcpu_thread(CPUState *cpu) >> +{ >> + cpus_kick_thread(cpu); >> +} > This won't build without an extra #include "sysemu/cpus.h". > I've folded in the fix.
Thanks a lot! I test compiled all the earlier versions of the patch set on x86 as well, but no longer have easy access to an x86 macOS system :(. They're just so insanely slow in comparison! Alex