On Fri, Sep 17, 2021 at 10:11 AM Ani Sinha <a...@anisinha.ca> wrote: > > > > On Thu, 16 Sep 2021, Michael S. Tsirkin wrote: > > > On Thu, Sep 16, 2021 at 06:58:35PM +0530, Ani Sinha wrote: > > > Here's sending v2. > > > > > > changelog : > > > v1: original patch. > > > v2: typo fixed. reviewed-by tags added. > > > > > > Thanks, tagged! > > Ani pls make sure the voer letter in the series has > > subject > > > > [PATCH 0/3] hw/i386/acpi: fix conflicting IO address range for acpi pci > > hotplug in q35 > > > > > > using --cover-letter with git format-patch will do this automatically. > > > > It will also include diffstat and other useful info. > > Ah I see. I was wondering about this few days back because I saw a > patchset with diffstat etc. I use git send-email --cover -v2 -3 -cc > --cc-cmd etc. I did not realize that git format-patch also has similar > options and adds more info to the cover letter. I wonder why the behavior > is different between them. Also --cc-cmd is missing in format-patch!
Also note that checkpatch.pl can be run without spitting out the patches in separate files: ./scripts/checkpatch.pl HEAD~3..HEAD 1/3 Checking commit 0a4f1a3d8733 (bios-tables-test: allow changes in DSDT ACPI tables for q35) total: 0 errors, 0 warnings, 12 lines checked Patch 1/3 has no obvious style problems and is ready for submission. 2/3 Checking commit 5adcc9e39e6a (hw/i386/acpi: fix conflicting IO address range for acpi pci hotplug in q35) total: 0 errors, 0 warnings, 8 lines checked Patch 2/3 has no obvious style problems and is ready for submission. 3/3 Checking commit 5e0a8181d2d9 (bios-tables-test: Update ACPI DSDT table golden blobs for q35) total: 0 errors, 0 warnings, 1 lines checked Patch 3/3 has no obvious style problems and is ready for submission. So I guess the workflow should always be : 1) use git format-patch -o <dir> 2) run checkpatch on patches in dir 3) git send-email dir/*.patch > > Was this an essential complexity or accidental one :-) > > > > > > > > > > This issue has been reported here: > > > https://gitlab.com/qemu-project/qemu/-/issues/561 > > > > > > We have disucssed this issue at length here: > > > https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg02146.html > > > > > > This issue affects Qemu version 6.1. > > > > > > Patch 1 : allows q35 DSDT table changes. > > > Patch 2 : actual fix. > > > Patch 3: updates DSDT table blobs. > > > > > > > > > >
