On Wed, Sep 08, 2021 at 10:32:27AM +0200, Philippe Mathieu-Daudé wrote:
> On 9/8/21 10:19 AM, Yang Zhong wrote:
> > Add the sgx_get_info() interface for hmp and QMP usage, which
> > will get the SGX info from this API.
> >
> > Signed-off-by: Yang Zhong <yang.zh...@intel.com>
> > ---
> > hw/i386/sgx.c | 21 +++++++++++++++++++++
> > include/hw/i386/sgx.h | 11 +++++++++++
> > target/i386/monitor.c | 32 ++++++++++++++++++++++++++++----
> > 3 files changed, 60 insertions(+), 4 deletions(-)
> > create mode 100644 include/hw/i386/sgx.h
>
> > @@ -766,12 +767,35 @@ qmp_query_sev_attestation_report(const char *mnonce,
> > Error **errp)
> >
> > SGXInfo *qmp_query_sgx(Error **errp)
> > {
> > - error_setg(errp, QERR_FEATURE_DISABLED, "query-sgx");
>
> > void hmp_info_sgx(Monitor *mon, const QDict *qdict)
> > {
> > - error_setg(errp, QERR_FEATURE_DISABLED, "query-sgx");
> > - return NULL;
>
> What is the point of patches #1 & #2? Why not squash all here?
Philippe, The different user usage, Monitor and QMP tool to get the some info
from VM.
I am okay to squash those 3 patches into ones, thanks!
Yang
