On 9/5/21 4:34 PM, Peter Delevoryas wrote: > > >> On Sep 5, 2021, at 1:51 AM, Cédric Le Goater <c...@kaod.org> wrote: >> >> On 9/5/21 1:03 AM, Philippe Mathieu-Daudé wrote: >>>> On 9/4/21 7:33 AM, Cédric Le Goater wrote: >>>> On 9/3/21 10:41 PM, Philippe Mathieu-Daudé wrote: >>>>> Hi Peter, >>>>> >>>>> On 9/3/21 9:40 PM, Cédric Le Goater wrote: >>>>>> The following changes since commit >>>>>> 8880cc4362fde4ecdac0b2092318893118206fcf: >>>>>> >>>>>> Merge remote-tracking branch >>>>>> 'remotes/cschoenebeck/tags/pull-9p-20210902' into staging (2021-09-03 >>>>>> 08:27:38 +0100) >>>>>> >>>>>> are available in the Git repository at: >>>>>> >>>>>> https://github.com/legoater/qemu/ tags/pull-aspeed-20210903 >>>>>> >>>>>> for you to fetch changes up to 907796622b2a6b945c87641d94e254ac898b96ae: >>>>>> >>>>>> hw/arm/aspeed: Add Fuji machine type (2021-09-03 18:43:16 +0200) >>>>>> >>>>>> ---------------------------------------------------------------- >>>>>> Aspeed patches : >>>>>> >>>>>> * MAC enablement fixes (Guenter) >>>>>> * Watchdog and pca9552 fixes (Andrew) >>>>>> * GPIO fixes (Joel) >>>>>> * AST2600A3 SoC and DPS310 models (Joel) >>>>>> * New Fuji BMC machine (Peter) >>>>>> >>>>>> ---------------------------------------------------------------- >>>>> >>>>>> Peter Delevoryas (3): >>>>>> hw/arm/aspeed: Initialize AST2600 UART clock selection registers >>>>>> hw/arm/aspeed: Allow machine to set UART default >>>>>> hw/arm/aspeed: Add Fuji machine type >>>>> >>>>> I have a pending question with the last patch, do you mind holding >>>>> this PR until it is resolved with Cédric and the patch author please? >>>>> >>>>> Thanks, >>>>> >>>>> Phil. >>>>> >>>> >>>> I guess we can drop the following from the commit log : >>>> >>>> git clone https://github.com/facebook/openbmc >>>> cd openbmc >>>> ./sync_yocto.sh >>>> source openbmc-init-build-env fuji build-fuji >>>> bitbake fuji-image >>>> dd if=/dev/zero of=/tmp/fuji.mtd bs=1M count=128 >>>> dd if=./tmp/deploy/images/fuji/flash-fuji of=/tmp/fuji.mtd \ >>>> bs=1k conv=notrunc >>>> >>>> git clone --branch aspeed-next https://github.com/peterdelevoryas/qemu >>>> cd qemu >>>> ./configure --target-list=arm-softmmu --disable-vnc >>>> make -j $(nproc) >>>> ./build/arm-softmmu/qemu-system-arm \ >>>> -machine fuji-bmc \ >>>> -drive file=/tmp/fuji.mtd,format=raw,if=mtd \ >>>> -serial stdio \ >>>> -nic user,hostfwd=::2222-:22 >>>> sshpass -p 0penBmc ssh root@localhost -p 2222 >>> >>> Sounds good. Eventually document that in docs/system/arm/aspeed.rst >>> in a follow up patch? >>> >>> Regards, >>> >>> Phil. >>> >> >> >> Peter D, >> >> Could you please resend the "hw/arm/aspeed: Add Fuji machine type" >> patch addressing Phil's comment. I will resend a PR with the >> update. >> >> Thanks, >> >> C. >> >> > > Oh! Yes, I can do that, sorry, I wasn’t sure if it was necessary to resend or > if it could be fixed inline or something. I’ll send that within the next 24 > hrs, removing the selected text from the commit description.
I didn't either. Thanks, C.
