Am 24.10.2011 17:28, schrieb Paolo Bonzini: > On 10/24/2011 05:28 PM, Kevin Wolf wrote: >>> scsi-block is a new device that supports device passthrough of Linux >>>> block devices (i.e. /dev/sda, not /dev/sg0). It uses SG_IO for commands >>>> other than I/O commands, and regular AIO read/writes for I/O commands. >>>> Besides being simpler to configure (no mapping required to scsi-generic >>>> device names), this removes the need for a large bounce buffer and, >>>> in the future, will get scatter/gather support for free from scsi-disk. >>>> >>>> Signed-off-by: Paolo Bonzini<pbonz...@redhat.com> >> >> This doesn't seem to use much of scsi-disk, so what about exporting >> &scsi_disk_reqops and adding a separate file scsi-block.c? Would make >> things a bit more symmetrical between scsi-disk and scsi-generic. >> >> Or will future patches add code that depends on internal interfaces of >> scsi-disk? > > It already uses some internal interfaces: scsi_initfn, scsi_disk_reset, > scsi_destroy, sizeof(SCSIDiskState).
Right... I don't like it much in scsi-disk.c, but what can you do. Exporting everything wouldn't be nicer. Kevin
