On Fri, Aug 27, 2021 at 04:50:35PM +0000, Raphael Norwitz wrote: > This change adds a command line option to print a line to standard out > when the storage daemon has completed initialization and is ready to > serve client connections. > > This option will be used to resolve a hang in the vhost-user-blk-test.
Doesn't the existing --pidfile already serve the same job? That is, why not fix vhost-user-blk-test to take advantage of the pid-file creation rather than output to stdout as evidence of when the storage daemon is up and running? Therefore, I don't think we need this patch. > > Signed-off-by: Raphael Norwitz <raphael.norw...@nutanix.com> > --- > storage-daemon/qemu-storage-daemon.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) Missing a corresponding change to the man page (docs/tools/qemu-storage-daemon.rst), if we decide to go with this after all. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
