On Thu, 26 Aug 2021 at 14:11, Peter Maydell <peter.mayd...@linaro.org> wrote:
>
> On Tue, 24 Aug 2021 at 21:12, <matheus.fe...@eldorado.org.br> wrote:
> >
> > From: Matheus Ferst <matheus.fe...@eldorado.org.br>
> >
> > Suggested-by: Peter Maydell <peter.mayd...@linaro.org>
> > Signed-off-by: Matheus Ferst <matheus.fe...@eldorado.org.br>
> > ---
>
> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Oh, you could add a comment before the struct definition:
/*
* We guarantee that the in-memory byte representation of an
* Int128 is that of a host-endian-order 128-bit integer
* (whether using this struct or the __int128_t version of the type).
* Some code using this type relies on this (eg when copying it into
* guest memory or a gdb protocol buffer, or by using Int128 in
* a union with other integer types).
*/
struct Int128 {
....
so we don't forget why we put this ifdef in.
-- PMM
