On Tue, Aug 24, 2021 at 09:48:30PM -0300, Daniel Henrique Barboza wrote: > As done in hw/acpi/memory_hotplug.c, pass an empty string if dev->id > is NULL to qapi_event_send_mem_unplug_error() to avoid relying on > a behavior that can be changed in the future. > > Suggested-by: Markus Armbruster <arm...@redhat.com> > Signed-off-by: Daniel Henrique Barboza <danielhb...@gmail.com>
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
> ---
> hw/ppc/spapr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 81699d4f8b..4f1ee90e9e 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -3690,7 +3690,7 @@ void spapr_memory_unplug_rollback(SpaprMachineState
> *spapr, DeviceState *dev)
> */
> qapi_error = g_strdup_printf("Memory hotunplug rejected by the guest "
> "for device %s", dev->id);
> - qapi_event_send_mem_unplug_error(dev->id, qapi_error);
> + qapi_event_send_mem_unplug_error(dev->id ? : "", qapi_error);
> }
>
> /* Callback to be called during DRC release. */
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
