On Fri, 20 Aug 2021 at 18:02, Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > > On 8/20/21 6:55 PM, Peter Maydell wrote: > > On Tue, 11 May 2021 at 09:22, Paolo Bonzini <pbonz...@redhat.com> wrote: > >> > >> From: Claudio Fontana <cfont...@suse.de> > >> > >> i386 is the first user of AccelCPUClass, allowing to split > >> cpu.c into: > >> > >> cpu.c cpuid and common x86 cpu functionality > >> host-cpu.c host x86 cpu functions and "host" cpu type > >> kvm/kvm-cpu.c KVM x86 AccelCPUClass > >> hvf/hvf-cpu.c HVF x86 AccelCPUClass > >> tcg/tcg-cpu.c TCG x86 AccelCPUClass > >> > >> Signed-off-by: Claudio Fontana <cfont...@suse.de> > >> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> > >> Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > >> > >> [claudio]: > >> Rebased on commit b8184135 ("target/i386: allow modifying TCG > >> phys-addr-bits") > >> > >> Signed-off-by: Claudio Fontana <cfont...@suse.de> > >> Message-Id: <20210322132800.7470-5-cfont...@suse.de> > >> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > >> --- > > > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index b692c8fbee..c2723b32cb 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -351,7 +351,7 @@ M: Paolo Bonzini <pbonz...@redhat.com> > >> M: Richard Henderson <richard.hender...@linaro.org> > >> M: Eduardo Habkost <ehabk...@redhat.com> > >> S: Maintained > >> -F: target/i386/ > >> +F: target/i386/tcg/ > >> F: tests/tcg/i386/ > >> F: tests/tcg/x86_64/ > >> F: hw/i386/ > > > > This change to MAINTAINERS has left all the .c files > > in target/i386 that are not in one of the tcg, hvf, whpx, > > kvm, hax, nvmm subdirectories orphaned -- they are no > > longer covered by any MAINTAINERS section. > > > > Where should those files be listed ? > > > > (I just discovered this when get_maintainers.pl said it couldn't > > find a maintainer for a change I made to target/i386/sev.c.) > > This patch maybe got lost: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg816326.html
Looks like it, but we should have a general fallback for target/i386 as well... -- PMM