On Thu, Oct 20, 2011 at 11:05:33AM +0200, Paolo Bonzini wrote: > On 10/20/2011 10:03 AM, Stuart Brady wrote: > >Coccinelle did not match these when matching assignments involving an > >expression corresponding to the type used for determining the size to > >allocate. > > They all look okay, perhaps the include path you passed to > Coccinelle is incomplete?
Ah, good point! I'm not sure what include dirs are needed, though... anyone have any advice? Blue Swirl, I gather you're one of the few other people to have used Coccinelle with Qemu's source... > Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> > > but would be nicer if you fixed the problem. Agreed... I'm new to Coccinelle, but I'll experiment and see if I can produce a better patch. After applying my patch series, it seems there are still some additional calls that need converting, so I can readily believe that the semantic patches I've used can be improved! Cheers, -- Stuart
