On Aug 3 12:54, Padmakar Kalghatgi wrote: > From: padmakar <p.kalgha...@samsung.com> > > This patch contains the implementation of certain commands > of nvme-mi specification.The MI commands are useful to > manage/configure/monitor the device.Eventhough the MI commands > can be sent via the inband NVMe-MI send/recieve commands, the idea > here is to emulate the sideband interface for MI. > > The changes here includes the interface for i2c/smbus > for nvme-mi protocol. We have used i2c address of 0x15 > using which the guest VM can send and recieve the nvme-mi > commands. Since the nvme-mi device uses the I2C_SLAVE as > parent, we have used the send and recieve callbacks by > which the nvme-mi device will get the required notification. > With the callback approach, we have eliminated the use of > threads. > > One needs to specify the following command in the launch to > specify the nvme-mi device, link to nvme and assign the i2c address. > <-device nvme-mi,nvme=nvme0,address=0x15> > > This module makes use of the NvmeCtrl structure of the nvme module, > to fetch relevant information of the nvme device which are used in > some of the mi commands. Eventhough certain commands might require > modification to the nvme module, currently we have currently refrained > from making changes to the nvme module. > > cmd-name cmd-type > ************************************************* > read nvme-mi ds nvme-mi > configuration set nvme-mi > configuration get nvme-mi > vpd read nvme-mi > vpd write nvme-mi > controller Health Staus Poll nvme-mi > nvme subsystem health status poll nvme-mi > identify nvme-admin > get log page nvme-admin > get features nvme-admin > > Signed-off-by: Padmakar Kalghatgi <p.kalgha...@samsung.com> > Reviewed-by: Klaus Birkelund Jensen <k.jen...@samsung.com> > Reviewed-by: Jaegyu Choi <jg123.c...@samsung.com> >
My Reviewed-by here was added by mistake. I've not given it my formal R-b, but I'll provide a proper review on-list ASAP. But just glossing over it, I like this approach a lot better than v1 (vsock).
signature.asc
Description: PGP signature
