On Tue, 17 Aug 2021 at 10:25, BALATON Zoltan <bala...@eik.bme.hu> wrote: > We could also modify the pc-bios/canyonlands.dts to comment out the > ethernet ports from it or add the disabled properties there, maybe also > adding a comment that explains these are not emulated in QEMU but to me > keeping the dts unmodified, matching real hardware and let the board code > patch it according to what's emulated looks more obvious to clearly show > what changes we have from the originial hardware which would be less clear > if we loaded a modified dtb. Modifying the dtb simplifies the board code > but hides the differences from real hardware. So since we already have to > modify the loaded dtb anyway I'm OK with changing it at the same place as > this patch proposes.
If this was preventing Linux from booting then I'd be a bit more inclined to it. But it doesn't sound like it's actually doing that? AIUI you just get a couple of non-functional ethernet interfaces that can be ignored, and "some devices don't actually work" is pretty much par-for-the-course for most QEMU models... -- PMM
