On 8/5/21 12:56 AM, Ilya Leoshkevich wrote:
On Wed, 2021-08-04 at 14:30 -1000, Richard Henderson wrote:
I think that the translator_ld*_swap functions should be moved out of
include/exec/translator.h into accel/tcg/translator.c.
Do we really need this? In the end, the added code is not that large.
I suppose it's not required, but they're already larger than they need to be.
In my opinion, if you're going to swap one out-of-line function call for two out-of-line
function calls (cpu_ld*_code + plugin_insn_append), you've probably made a bad size trade-off.
With your added code, it'll be 3 out-of-line calls.
r~
