Hi On Tue, Aug 3, 2021 at 5:44 PM Markus Armbruster <arm...@redhat.com> wrote:
> marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > Hi, > > > > This series makes the 'if' conditions less liberal, by formalizing a > simple > > expression tree based on bare boolean logic of configure option > identifiers. > > > > (this allows to express conditions in Rust in my QAPI-Rust PoC series) > > > > thanks > > I like this overall. > > The commit messages are rather terse in places. I have a few questions, > I asked for a few minor tweaks, and I also noted a few possible > improvements that can be done on top. I wonder whether we can drop > PATCH 04. > > Let's discuss my findings, then decide whether we want a respin. > Thanks, I am sending v7 with the requested changes.
