On 7/28/21 4:03 PM, Guenter Roeck wrote: > On 7/28/21 6:25 AM, Ard Biesheuvel wrote: >> On Wed, 28 Jul 2021 at 15:11, Michael S. Tsirkin <m...@redhat.com> wrote: >>> >>> On Tue, Jul 27, 2021 at 12:36:03PM +0200, Igor Mammedov wrote:
>>> As others noted the original commit was kind of vague: >>> >>> 1. it said "Using _DSM #5 method to inform guest os not to ignore the >>> PCI configuration >>> that firmware has done at boot time could handle the differences." >>> which is not what the spec says and not what the patch did - >>> guest os does not ignore configuration even without this, >>> it is just allowed to change it. >>> >>> >>> 2. is says could result but does not report whether that happened in the >>> field. >>> >>> >>> Given this causes a regression I'm inclined to just revert for now. >>> We can figure it out for the next release. >>> >> >> For a revert of commit 0cf8882fd06ba0aeb1e90fa6f23fce85504d7e14, feel >> free to include >> >> Acked-by: Ard Biesheuvel <a...@kernel.org> >> > > and: > > Tested-by: Guenter Roeck <li...@roeck-us.net> > >> and please also involve me if any future debates on this subject flare >> up again. Thanks all, this thread has been very instructive. Michael, if describing the issue in the revert is too complex, could you include a link to this thread in the revert description? (Message-Id: <20210724185234.ga2265...@roeck-us.net> or https://www.mail-archive.com/qemu-devel@nongnu.org/msg826392.html)
