On Sun, 18 Jul 2021 at 08:46, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > The difference between "signal-common.h" and "sighandling.h" > is not clear. Could they be merged?
Yeah, you're right, we don't really need two separate headers here. (signal-common.h was originally "the stuff that signal.c and the per-target-arch signal.c need to share", from when we split the per-arch stuff out of signal.c, whereas the stuff that was in qemu.h and this patch moves into sighandling.h is the interface between the signals code and the rest of linux-user; but this doesn't really seem like a very clear or obviously useful distinction.) -- PMM