On Mon, Jul 12, 2021 at 02:55:31PM -0700, Richard Henderson wrote: > >From clang-13: > hw/pci-host/pnv_phb4.c:375:18: error: variable 'v' set but not used \ > [-Werror,-Wunused-but-set-variable] > > It's pretty clear that we meant to write back 'v' after > all that computation and not 'val'. > > Cc: qemu-...@nongnu.org > Cc: Greg Kurz <gr...@kaod.org> > Cc: David Gibson <da...@gibson.dropbear.id.au> > Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
Acked-by: David Gibson <da...@gibson.dropbear.id.au>
> ---
> hw/pci-host/pnv_phb4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
> index 54f57c660a..5c375a9f28 100644
> --- a/hw/pci-host/pnv_phb4.c
> +++ b/hw/pci-host/pnv_phb4.c
> @@ -392,7 +392,7 @@ static void pnv_phb4_ioda_write(PnvPHB4 *phb, uint64_t
> val)
> v &= 0xffffffffffff0000ull;
> v |= 0x000000000000cfffull & val;
> }
> - *tptr = val;
> + *tptr = v;
> break;
> }
> case IODA3_TBL_MBT:
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
