On Fri, Jul 09, 2021 at 09:00:30AM -0700, Richard Henderson wrote: > Ping. > > On 6/19/21 11:23 PM, Richard Henderson wrote: > > The loop is performing a simple boolean test for the existence > > of a BP_CPU breakpoint at EIP. Plus it gets the iteration wrong, > > if we happen to have a BP_GDB breakpoint at the same address. > > > > We have a function for this: cpu_breakpoint_test. > > > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
cpu_breakpoint_test() logic matches the existing code being replaced, so: Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> I wouldn't have objected if you simply merged this without waiting for review from others, though. I believe you know this code better than anybody else. -- Eduardo
