On Thu, Jul 08, 2021 at 02:35:19PM -0500, Eric Blake wrote: > On Tue, Jul 06, 2021 at 10:59:22AM +0100, Daniel P. Berrangé wrote: > > This adds support for using gnutls as a provider of the crypto > > hmac APIs. > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > crypto/hmac-gnutls.c | 136 +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 136 insertions(+) > > create mode 100644 crypto/hmac-gnutls.c > > > > diff --git a/crypto/hmac-gnutls.c b/crypto/hmac-gnutls.c > > new file mode 100644 > > index 0000000000..ea33b5753b > > --- /dev/null > > +++ b/crypto/hmac-gnutls.c > > @@ -0,0 +1,136 @@ > > +/* > > + * QEMU Crypto hmac algorithms > > + * > > + * Derived from hmac-gcrypt.c: > > + * > > + * Copyright (c) 2016 HUAWEI TECHNOLOGIES CO., LTD. > > Is this line correct?
This is referring to the statement above "Derived from..." I should have /also/ added a Red Hat copyright before though > > > + * > > + * This work is licensed under the terms of the GNU GPL, version 2 or > > + * (at your option) any later version. See the COPYING file in the > > + * top-level directory. > > + * > > + */ > > + > > +#include "qemu/osdep.h" > > +#include "qapi/error.h" > > +#include "crypto/hmac.h" > > +#include "hmacpriv.h" > > +#include <gnutls/crypto.h> > > Should you favor floating this to be right after "qemu/osdep.h"? yeah good idea > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
