Re: [PATCH v8 6/9] virtio-mmio: add support for configure interrupt

[Jason Wang]

在 2021/7/6 下午3:20, Cindy Lu 写道:

Add configure interrupt support for virtio-mmio bus. This
interrupt will working while backend is vhost-vdpa

Signed-off-by: Cindy Lu <l...@redhat.com>
---
  hw/virtio/virtio-mmio.c | 26 ++++++++++++++++++++++++++
  1 file changed, 26 insertions(+)

diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c
index 342c918ea7..6c786db071 100644
--- a/hw/virtio/virtio-mmio.c
+++ b/hw/virtio/virtio-mmio.c
@@ -670,7 +670,29 @@ static int virtio_mmio_set_guest_notifier(DeviceState *d, 
int n, bool assign,

return 0;

  }
+static int virtio_mmio_set_config_notifier(DeviceState *d, bool assign)
+{

We had similar issue as previous patch.

We need use "virtio_mmio_set_config_guest_notifier()."

Thanks

+    VirtIOMMIOProxy *proxy = VIRTIO_MMIO(d);
+    VirtIODevice *vdev = virtio_bus_get_device(&proxy->bus);
+    VirtioDeviceClass *vdc = VIRTIO_DEVICE_GET_CLASS(vdev);

+ EventNotifier *notifier = virtio_get_config_notifier(vdev);

+    int r = 0;
+    if (assign) {
+        r = event_notifier_init(notifier, 0);
+        if (r < 0) {
+            return r;
+        }
+        virtio_set_config_notifier_fd_handler(vdev, true, false);
+    } else {
+        virtio_set_config_notifier_fd_handler(vdev, false, false);
+        event_notifier_cleanup(notifier);
+    }
+    if (vdc->guest_notifier_mask && vdev->use_guest_notifier_mask) {
+        vdc->guest_notifier_mask(vdev, VIRTIO_CONFIG_IRQ_IDX, !assign);
+    }
+    return r;
+}
  static int virtio_mmio_set_guest_notifiers(DeviceState *d, int nvqs,
                                             bool assign)
  {
@@ -692,6 +714,10 @@ static int virtio_mmio_set_guest_notifiers(DeviceState *d, 
int nvqs,
              goto assign_error;
          }
      }
+    r = virtio_mmio_set_config_notifier(d, assign);
+    if (r < 0) {
+        goto assign_error;
+    }

return 0;