On Thu, Jul 08, 2021 at 02:39:57PM -0400, Cole Robinson wrote: > It's not installed in any way, so seems like contrib/ material
Not really. Contrib is stuff that is included on an ad-hoc basis with no commitment to support and no guarantee that it is working at all. Yes, there is some stuff in contrib/ that doesn't belong there based on this definition, and should be moved out. The SASL config is most definitely supported, so doesn't belong in there. > > Signed-off-by: Cole Robinson <crobi...@redhat.com> > --- > Or should this be installed to /etc/sasl2 ? > > MAINTAINERS | 2 +- > qemu.sasl => contrib/qemu.sasl | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename qemu.sasl => contrib/qemu.sasl (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 684142e12e..2ec1c362f0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2768,7 +2768,7 @@ F: tests/unit/test-crypto-* > F: tests/bench/benchmark-crypto-* > F: tests/unit/crypto-tls-* > F: tests/unit/pkix_asn1_tab.c > -F: qemu.sasl > +F: contrib/qemu.sasl > > Coroutines > M: Stefan Hajnoczi <stefa...@redhat.com> > diff --git a/qemu.sasl b/contrib/qemu.sasl > similarity index 100% > rename from qemu.sasl > rename to contrib/qemu.sasl > -- > 2.31.1 > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|