Daniel P. Berrangé <berra...@redhat.com> writes:
> On Mon, Jul 05, 2021 at 10:41:55PM +0100, Daniel P. Berrangé wrote: >> On Mon, Jul 05, 2021 at 09:27:56PM +0100, Alex Bennée wrote: >> > >> > Daniel P. Berrangé <berra...@redhat.com> writes: >> > >> > > This is the fully expanded list of build pre-requisites QEMU can >> > > conceivably use in any scenario. >> > > >> > > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> >> > > --- >> > > tests/docker/dockerfiles/centos8.docker | 68 +++++++++++++++++++++++++ >> > > 1 file changed, 68 insertions(+) >> > > >> > > diff --git a/tests/docker/dockerfiles/centos8.docker >> > > b/tests/docker/dockerfiles/centos8.docker >> > > index 5f1c57b4ad..4cc4c0c8a1 100644 >> > > --- a/tests/docker/dockerfiles/centos8.docker >> > > +++ b/tests/docker/dockerfiles/centos8.docker >> > > @@ -3,36 +3,104 @@ FROM docker.io/centos:8 >> > > RUN dnf -y update >> > > ENV PACKAGES \ >> > > SDL2-devel \ >> > > + alsa-lib-devel \ >> > > + bc \ >> > > + brlapi-devel \ >> > > bzip2 \ >> > > bzip2-devel \ >> > > + ca-certificates \ >> > > + capstone-devel \ >> > >> > CentOS8 doesn't seem to package capstone-devel or is it meant to come >> > from somewhere else? >> >> It comes in via the EPEL repository, along with a few other of the >> packages listed here. Take a look at this job, line 1385 onwards: >> >> https://gitlab.com/berrange/qemu/-/jobs/1369975075 > > Oh actually, this is a bisect issue in the series. The EPEL and > advanced virt repos are only enabled in the later patch in the > series that converts to lcitool auto-generation. > > IOW, this current patch should have gained: > > RUN dnf install -y dnf-plugins-core && \ > dnf config-manager --set-enabled powertools && \ > + dnf install -y centos-release-advanced-virtualization && \ > + dnf install -y epel-release && \ > dnf install -y $PACKAGES OK I'll revert my deletions and fix that up. > > > Regards, > Daniel -- Alex Bennée
