On 03/07/2021 23.12, Richard Zak wrote:
Fix for path to env
Please change the subject to something more meaning full, e.g. "Fix setting
of the SHELL variable for Haiku".
In the patch description, you should mention that there is no /usr/bin/env
on Haiku.
Signed-off-by: Richard Zak <richard.j....@gmail.com
<mailto:richard.j....@gmail.com>>
---
Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile
index 30f19d33bb..ced9b97372 100644
--- a/Makefile
+++ b/Makefile
@@ -14,7 +14,11 @@ SRC_PATH=.
# we have explicit rules for everything
MAKEFLAGS += -rR
+ifneq ($(BE_HOST_CPU),)
+SHELL = /bin/env bash -o pipefail
+else
SHELL = /usr/bin/env bash -o pipefail
+endif
Actually, I wonder why we had to take the detour via /usr/bin/env here at
all? Couldn't we simply set
SHELL = bash -o pipefail
by default, or does this cause some trouble on other systems?
If nobody objects, I'd suggest that you change your patch to always set
"SHELL = bash -o pipefail" unconditionally.
Thomas
