On 7/2/21 12:40 PM, Peter Maydell wrote: > The PL061 comes out of reset with all its lines configured as input, > which means they might need to be pulled to 0 or 1 depending on the > 'pullups' and 'pulldowns' properties. Currently we do not assert > these lines on reset; they will only be set whenever the guest first > touches a register that triggers a call to pl061_update(). > > Convert the device to three-phase reset so we have a place where we > can safely call qemu_set_irq() to set the floating lines to their > correct values. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > hw/gpio/pl061.c | 29 +++++++++++++++++++++++++---- > hw/gpio/trace-events | 1 + > 2 files changed, 26 insertions(+), 4 deletions(-)
Nice. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>