On Thu, 2021-07-01 at 14:35 +0200, Thomas Huth wrote: > On 29/06/2021 16.19, Cho, Yu-Chen wrote: > > Splitting this functionality also allows us to make helper.c sysemu- > > only. > > > > Signed-off-by: Claudio Fontana <cfont...@suse.de> > > Signed-off-by: Cho, Yu-Chen <a...@suse.com> > > Acked-by: Cornelia Huck <coh...@redhat.com> > > --- > > target/s390x/cpu-dump.c | 176 > > +++++++++++++++++++++++++++++++++++++++ > > Apart from the dump() function, the other functions here are are used > in > other contexts, too, so maybe the name is not very appropriate here... > What > about naming it "cpu-state.c" instead? Or include the functions in > cpu.c > directly? >
ok, I think naming it "cpu-state.c" would make more sense. Thanks, AL