Hi Nolan, Peter, On 6/25/21 11:02 PM, Nolan Leake wrote: > This is just enough to make reboot and poweroff work. Works for > linux, u-boot, and the arm trusted firmware. Not tested, but should > work for plan9, and bare-metal/hobby OSes, since they seem to generally > do what linux does for reset. > > The watchdog timer functionality is not yet implemented. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/64
Please carry the tags from previous versions (if the changes are minor). Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> > Signed-off-by: Nolan Leake <no...@sigbus.net> > --- > hw/arm/bcm2835_peripherals.c | 13 ++- > hw/misc/bcm2835_powermgt.c | 160 +++++++++++++++++++++++++++ > hw/misc/meson.build | 1 + > include/hw/arm/bcm2835_peripherals.h | 3 +- > include/hw/misc/bcm2835_powermgt.h | 29 +++++ > 5 files changed, 204 insertions(+), 2 deletions(-) > create mode 100644 hw/misc/bcm2835_powermgt.c > create mode 100644 include/hw/misc/bcm2835_powermgt.h > > diff --git hw/arm/bcm2835_peripherals.c hw/arm/bcm2835_peripherals.c Odd, usually the diff line comes with a/ b/ prefix, I can not apply your patch (git version 2.31.1, Fedora): Applying: Add basic power management to raspi. error: arm/bcm2835_peripherals.c: does not exist in index error: misc/meson.build: does not exist in index error: hw/arm/bcm2835_peripherals.h: does not exist in index Patch failed at 0001 Add basic power management to raspi. But patchew succeeded: https://patchew.org/QEMU/20210625210209.1870217-1-no...@sigbus.net/ Applying: Add basic power management to raspi. Using index info to reconstruct a base tree... A arm/bcm2835_peripherals.c A hw/arm/bcm2835_peripherals.h A misc/meson.build Falling back to patching base and 3-way merge... So I tested patchew's commit 7856ac0e804: https://github.com/patchew-project/qemu/commit/7856ac0e8045d006f1008a03e1d4d8710b9d0612 Peter, when queueing this patch (maybe prepending hw/arm: or hw/arm/raspi: to the subject), can you take the corresponding test along - which is already reviewed? https://www.mail-archive.com/qemu-devel@nongnu.org/msg811909.html Thanks both, Phil.
