On Thu, Jun 24, 2021 at 03:55:29PM +0100, Dr. David Alan Gilbert wrote:
> * Gerd Hoffmann (kra...@redhat.com) wrote:
> > Allow commands having a NULL cmd pointer, add a function to set the
> > pointer later. Use case: allow modules implement hmp commands.
> >
> > Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
>
> So this is OK, so
>
> Acked-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
>
> however, I can imagine:
> a) Auto load as you suggest
Not sure about that. The tcg monitor commands are pointless when you
picked another accelerator, and "info usbhost" would probably also be
most useful when trouble-shooting usb-host issues. That's why I left
it as FIXME question for now. But can certainly be done, we can add
something along the lines of 'module_hmp("info usbhost");' to the
meta-data database and autoload based on that (or use it for more
verbose error messages).
> c) Don't actually define the command in the tables at all; make
> the module actually add the command to the table.
Another possible approach. I don't see a need for modules to expand the
list of commands though, so I only set the function pointer for existing
table entries ...
take care,
Gerd
