On Thu, Jun 17, 2021 at 10:12:08PM +0800, huang...@chinatelecom.cn wrote:
> @@ -487,12 +646,23 @@ void hmp_info_dirty_rate(Monitor *mon, const QDict
> *qdict)
> info->sample_pages);
> monitor_printf(mon, "Period: %"PRIi64" (sec)\n",
> info->calc_time);
> + monitor_printf(mon, "Mode: %s\n",
> + DirtyRateMeasureMode_str(info->mode));
> monitor_printf(mon, "Dirty rate: ");
> if (info->has_dirty_rate) {
> monitor_printf(mon, "%"PRIi64" (MB/s)\n", info->dirty_rate);
> + if (info->has_vcpu_dirty_rate) {
> + DirtyRateVcpuList *rate, *head = info->vcpu_dirty_rate;
> + for (rate = head; rate != NULL; rate = rate->next) {
> + monitor_printf(mon, "vcpu[%"PRIi64"], Dirty rate:
> %"PRIi64"\n",
Maybe ending it with " (MB/s)" to match the dirty rate line?
Otherwise this patch looks good to me, thanks. It's just that I still have a
few trivial comments out there, so this patch still may need some adjustment.
> + rate->value->id, rate->value->dirty_rate);
> + }
> + }
> } else {
> monitor_printf(mon, "(not ready)\n");
> }
> +
> + qapi_free_DirtyRateVcpuList(info->vcpu_dirty_rate);
> g_free(info);
> }
--
Peter Xu
