On Thu, Jun 17, 2021 at 01:53:19PM +0200, Philippe Mathieu-Daudé wrote: > Full series reviewed, all comments addressed. > > Corey, could you take this via your tree?
Ok. I'll do some testing then request a pull. -corey > > Regards, > > Phil. > > This is a respin of Zoltan's patch: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg714711.html > > Since v4: > - removed assertion in i2c_do_start_transfer (Richard) > - added Richard R-b tags > > Since v3: > - addressed minor review comments from Richard/Corey > - added R-b/A-b tags > - implemented Richard suggestion (last 2 patches, 14 & 15) > > Since v2, tried to address Corey's review comments resulting > in a i2c_send_recv() removal and code easier to review (to my > taste at least). > > BALATON Zoltan (1): > hw/i2c: Make i2c_start_transfer() direction argument a boolean > > Philippe Mathieu-Daudé (14): > hw/input/lm832x: Move lm832x_key_event() declaration to "lm832x.h" > hw/input/lm832x: Define TYPE_LM8323 in public header > hw/display/sm501: Simplify sm501_i2c_write() logic > hw/display/sm501: Replace i2c_send_recv() by i2c_recv() & i2c_send() > hw/i2c/ppc4xx_i2c: Add reference to datasheet > hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send() > hw/misc/auxbus: Fix MOT/classic I2C mode > hw/misc/auxbus: Explode READ_I2C / WRITE_I2C_MOT cases > hw/misc/auxbus: Replace 'is_write' boolean by its value > hw/misc/auxbus: Replace i2c_send_recv() by i2c_recv() & i2c_send() > hw/i2c: Remove confusing i2c_send_recv() > hw/i2c: Rename i2c_set_slave_address() -> i2c_slave_set_address() > hw/i2c: Extract i2c_do_start_transfer() from i2c_start_transfer() > hw/i2c: Introduce i2c_start_recv() and i2c_start_send() > > include/hw/i2c/i2c.h | 46 +++++++++++++++++++++--- > include/hw/input/lm832x.h | 28 +++++++++++++++ > hw/arm/nseries.c | 3 +- > hw/arm/pxa2xx.c | 2 +- > hw/arm/spitz.c | 4 +-- > hw/display/ati.c | 2 +- > hw/display/sm501.c | 16 +++++---- > hw/display/xlnx_dp.c | 2 +- > hw/i2c/core.c | 76 ++++++++++++++++++++++----------------- > hw/i2c/imx_i2c.c | 2 +- > hw/i2c/pm_smbus.c | 4 +-- > hw/i2c/ppc4xx_i2c.c | 15 +++++--- > hw/i2c/smbus_master.c | 22 ++++++------ > hw/input/lm832x.c | 2 +- > hw/misc/auxbus.c | 70 ++++++++++++++++++++++++++---------- > MAINTAINERS | 1 + > 16 files changed, 207 insertions(+), 88 deletions(-) > create mode 100644 include/hw/input/lm832x.h > > -- > 2.31.1 > >
