Thanks for review and feedback. I shall rework those in v2.
Regards,
SweeAun
-----Original Message-----
From: Markus Armbruster <arm...@redhat.com>
Sent: Monday, June 14, 2021 11:01 PM
To: Eric Blake <ebl...@redhat.com>
Cc: Khor, Swee Aun <swee.aun.k...@intel.com>; Romli, Khairul Anuar
<khairul.anuar.ro...@intel.com>; qemu-devel@nongnu.org; Kasireddy, Vivek
<vivek.kasire...@intel.com>
Subject: Re: [PATCH] ui/gtk: Allow user to select monitor number to display
qemu in full screen through new gtk display option
Eric Blake <ebl...@redhat.com> writes:
> On Mon, Jun 14, 2021 at 04:05:42PM +0800, sweeaun wrote:
>> -display gtk,monitor-num=<value>
>>
>> Signed-off-by: sweeaun <swee.aun.k...@intel.com>
>> ---
>> qapi/ui.json | 3 ++-
>> qemu-options.hx | 2 +-
>> ui/gtk.c | 15 +++++++++++++++
>> 3 files changed, 18 insertions(+), 2 deletions(-)
>>
>> diff --git a/qapi/ui.json b/qapi/ui.json index 1052ca9c38..c3363c7ad5
>> 100644
>> --- a/qapi/ui.json
>> +++ b/qapi/ui.json
>> @@ -1041,7 +1041,8 @@
>> ##
>> { 'struct' : 'DisplayGTK',
>> 'data' : { '*grab-on-hover' : 'bool',
>> - '*zoom-to-fit' : 'bool' } }
>> + '*zoom-to-fit' : 'bool',
>> + '*monitor-num' : 'int' } }
>
> Missing documentation of the new member. Also, get rid of the tab damage.
Suggest to name it either @monitor-number or @monitor (because what else than
the number could 'int' be?)
