On 15/06/21 16:24, Daniel P. Berrangé wrote:
+ if not get_option('vte').auto() or have_system
+ vte = dependency('vte-2.91', version: '>=0.32.0',
+ method: 'pkg-config',
+ required: get_option('vte'),
+ kwargs: static_kwargs)
+ if not vte.found()
+ vte = dependency('vte-2.90', version: '>=0.32.0',
+ method: 'pkg-config',
+ required: get_option('vte'),
+ kwargs: static_kwargs)
+ endif
The old configure checks didn't have a version number How did you
decide on 0.32 ? This version number doesn't make a whole lot of
sense to me in the way it is used.
vte changes from ABI 2.90 to 2.91 in release 0.37, so you'll never
get a version less than that with vte-2.91 IIUC.
Meanwhile all our supported distros ship 2.91 API now AFAICT, so we
don't need the 2.90 code at all.
It did:
- vteminversion="0.32.0"
- if $pkg_config --exists "vte-2.91"; then
- vtepackage="vte-2.91"
- else
- vtepackage="vte-2.90"
- fi
- if $pkg_config --exists "$vtepackage >= $vteminversion"; then
but I will remove the check if that's doable.
Paolo
