On Thu, 3 Jun 2021 at 18:13, Peter Maydell <peter.mayd...@linaro.org> wrote: > > Currently the Arm code in target/arm/kvm64.c which decides whether > it should report memory errors via the ACPI GHES table works > only with the 'virt' board; in fact it won't even link if the > virt board is configured out of the QEMU binary. > > This patchset replaces those virt-specific checks with a single > new acpi_ghes_present() function which tells the caller whether > it's OK to report errors by calling acpi_ghes_record_errors(). > The mechanism we use is a simple flag in the AcpiGhesState > which gets sent if the board calls acpi_ghes_add_fw_cfg() to > set up the GHES stuff. > > We need also to provide 'stub' versions of both acpi_ghes_present() > and acpi_ghes_record_errors() so that we can link even if no > board using ACPI GHES has been configured into the binary. > > (You can test that this series is necessary by commenting out the > 'CONFIG_ARM_VIRT=y' line in default-configs/devices/arm-softmmu.mak > and building with KVM enabled on an AArch64 host.) > > I have tested with 'make' and 'make check' but nothing beyond > that; testing by somebody who has a guest setup that uses GHES > would be helpful just to check I haven't accidentally broken it.
Thanks for the review; I've applied this to target-arm.next. -- PMM
