On Wed, 9 Jun 2021 at 20:26, Richard Henderson <richard.hender...@linaro.org> wrote: > > On 6/7/21 9:58 AM, Peter Maydell wrote: > > Implement the MVE VQSHL insn (encoding T4, which is the > > vector-shift-by-vector version). > > > > The DO_SQSHL_OP and DO_UQSHL_OP macros here are derived from > > the neon_helper.c code for qshl_u{8,16,32} and qshl_s{8,16,32}. > > Ah, from before the sve2 merge, and associated cleanup. > There are now helper functions in vec_internal.h for this.
Ah, that's helpful. Annoyingly, the helper wants to take a uint32_t* for the "write to this when saturating" argument, and I have a bool*... -- PMM