Am 14.06.21 um 07:26 schrieb Philippe Mathieu-Daudé:
Commit 7de2e856533 made migration/qemu-file-channel.c include
"io/channel-tls.h" but forgot to add the new GNUTLS dependency
on Meson, leading to build failure on OSX:
[2/35] Compiling C object libmigration.fa.p/migration_qemu-file-channel.c.o
FAILED: libmigration.fa.p/migration_qemu-file-channel.c.o
cc -Ilibmigration.fa.p -I. -I.. -Iqapi [ ... ] -o
libmigration.fa.p/migration_qemu-file-channel.c.o -c
../migration/qemu-file-channel.c
In file included from ../migration/qemu-file-channel.c:29:
In file included from include/io/channel-tls.h:26:
In file included from include/crypto/tlssession.h:24:
include/crypto/tlscreds.h:28:10: fatal error: 'gnutls/gnutls.h' file not
found
#include <gnutls/gnutls.h>
^~~~~~~~~~~~~~~~~
1 error generated.
Reported-by: Stefan Weil <s...@weilnetz.de>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/407
Fixes: 7de2e856533 ("yank: Unregister function when using TLS migration")
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
---
RFC: Not tested on OSX. Stefan, do you know why this isn't covered
on Cirrus-CI? https://cirrus-ci.com/build/4876003651616768
Cirrus-CI does not install gnutls. That's easy to fix by adding it to
the list of installed packages.
And the patch does not fix the issue. I already had tried that and
similar changes in migration/meson.build.
Regards
Stefan
