Philippe Mathieu-Daudé <phi...@redhat.com> writes: > On 6/10/21 11:39 AM, Markus Armbruster wrote: >> Just code motion, so >> >> Acked-by: Markus Armbruster <arm...@redhat.com> >> >> Opportunity to wrap the long doc comment lines. Should be kept under 70 >> or so. > > Hmm is that a QAPI specific requirement? It is not enforced by > checkpatch, and still in the 80-90 grey area: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg763806.html
Consider why we limit line length at all: it's for *legibility*. Humans tend to have trouble following long lines with our eyes (I sure do). Typographic manuals suggest to limit columns to roughly 60 characters for exactly that reason[1]. Four levels of indentation plus 60 characters of actual text yields 76. We add a grey area to provide for the occasional case where deeper indentation pushes code of reasonable width beyond the "white" area, and breaking these lines would be less legible than making use of the grey area. The lines I referred to are long for no good reason. Wrapping them will improve legibility. > (I can do if respin required, but I'd rather have this catch earlier, > not at code movement). Before, during, after, or even not at all *clank*[2], your choice. > Thanks for the A-b! [1] https://en.wikipedia.org/wiki/Column_(typography)#Typographic_style [2] Sad sound of a can being kicked down the road
