On Mon, Jun 07, 2021 at 08:36:07AM +0200, Thomas Huth wrote: > On 05/06/2021 19.50, Ahmed Abouzied wrote: > > Identifiers with leading underscores followed by capital letters or > > underscores are reserved for C standards. > > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/369 > > > > Signed-off-by: Ahmed Abouzied <em...@aabouzied.com> > > --- > > include/hw/xen/interface/grant_table.h | 4 ++-- > > include/hw/xen/interface/io/blkif.h | 4 ++-- > > include/hw/xen/interface/io/console.h | 4 ++-- > > include/hw/xen/interface/io/fbif.h | 4 ++-- > > include/hw/xen/interface/io/kbdif.h | 4 ++-- > > include/hw/xen/interface/io/netif.h | 4 ++-- > > include/hw/xen/interface/io/protocols.h | 4 ++-- > > include/hw/xen/interface/io/ring.h | 4 ++-- > > include/hw/xen/interface/io/usbif.h | 4 ++-- > > 9 files changed, 18 insertions(+), 18 deletions(-) > > > > I hope the Xen people can comment on whether the underscores had a purpose > here or whether it's ok to remove them, thus: > > Cc: xen-de...@lists.xenproject.org > > From my QEMU-developer's side of view: > > Reviewed-by: Thomas Huth <th...@redhat.com> >
Nacked-by: Anthony PERARD <anthony.per...@citrix.com> Please don't change the header guards in include/hw/xen/interface/. This have been attempted before and result in build failures, see d1744bd3218daa820744c14572058491e4854399 (Revert xen/io/ring.h of "Clean up a few header guard symbols") Cheers, -- Anthony PERARD
