Re: [PATCH v16 88/99] target/arm: cpu64: rename arm_cpu_finalize_features

[Richard Henderson]

On 6/4/21 8:53 AM, Alex Bennée wrote:

@@ -469,11 +469,10 @@ static gchar *aarch64_gdb_arch_name(CPUState *cs)
      return g_strdup("aarch64");
  }

-void arm_cpu_finalize_features(ARMCPU *cpu, Error **errp)

+void aarch64_cpu_finalize_features(ARMCPU *cpu, Error **errp)
  {
      Error *local_err = NULL;

-#ifdef TARGET_AARCH64

      if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) {
          if (!cpu_sve_finalize_features(cpu, &local_err)) {
              error_propagate(errp, local_err);
@@ -492,7 +491,6 @@ void arm_cpu_finalize_features(ARMCPU *cpu, Error **errp)
              }
          }
      }
-#endif /* TARGET_AARCH64 */

The ifdef removal shouldn't be buried in a rename.


r~