Re: [PATCH v2 04/26] s390x/tcg: Simplify vop64_2() handling

[Richard Henderson]

On 5/17/21 7:27 AM, David Hildenbrand wrote:

+#define DEF_GVEC_VOP2_FN(NAME, FN, BITS)                                       
\
+void HELPER(gvec_##NAME##BITS)(void *v1, const void *v2, CPUS390XState *env,   
\
+                               uint32_t desc)                                  
\
+{                                                                              
\
+    const uint8_t erm = extract32(simd_data(desc), 4, 4);                      
\
+    const uint8_t se = extract32(simd_data(desc), 3, 1);                       
\

bool for se?  The argumemt to vopN_2 is bool...

Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~