On 5/30/21 12:49 PM, Lukas Jünger wrote: > Make function names consistent > > Signed-off-by: Lukas Jünger <lukas.juen...@greensocs.com> > --- > hw/char/sifive_uart.c | 44 +++++++++++++++++++++---------------------- > 1 file changed, 22 insertions(+), 22 deletions(-)
> @@ -183,9 +183,9 @@ SiFiveUARTState *sifive_uart_create(MemoryRegion > *address_space, hwaddr base, > SiFiveUARTState *s = g_malloc0(sizeof(SiFiveUARTState)); > s->irq = irq; > qemu_chr_fe_init(&s->chr, chr, &error_abort); > - qemu_chr_fe_set_handlers(&s->chr, uart_can_rx, uart_rx, uart_event, > - uart_be_change, s, NULL, true); > - memory_region_init_io(&s->mmio, NULL, &uart_ops, s, > + qemu_chr_fe_set_handlers(&s->chr, sifive_uart_can_rx, sifive_uart_rx, > + sifive_uart_event, sifive_uart_be_change, s, NULL, true); Incorrect indentation, otherwise: Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > + memory_region_init_io(&s->mmio, NULL, &sifive_uart_ops, s, > TYPE_SIFIVE_UART, SIFIVE_UART_MAX); > memory_region_add_subregion(address_space, base, &s->mmio); > return s; >
