On 5/25/21 3:44 PM, Peter Maydell wrote:
> Coverity complains that we don't check for failures from dup()
> and mkstemp(); add asserts that these syscalls succeeded.
>
> Fixes: Coverity CID 1432516, 1432574
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
> ---
> tests/unit/test-vmstate.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c
> index a001879585e..8d46af61511 100644
> --- a/tests/unit/test-vmstate.c
> +++ b/tests/unit/test-vmstate.c
> @@ -44,6 +44,7 @@ static QEMUFile *open_test_file(bool write)
> QIOChannel *ioc;
> QEMUFile *f;
>
Eventually move the assignation before the assertion:
-- >8 --
@@ -40,10 +40,12 @@ static int temp_fd;
/* Duplicate temp_fd and seek to the beginning of the file */
static QEMUFile *open_test_file(bool write)
{
- int fd = dup(temp_fd);
+ int fd;
QIOChannel *ioc;
QEMUFile *f;
+ fd = dup(temp_fd);
+ g_assert(fd >= 0);
lseek(fd, 0, SEEK_SET);
if (write) {
g_assert_cmpint(ftruncate(fd, 0), ==, 0);
---
Regardless:
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> + g_assert(fd >= 0);
> lseek(fd, 0, SEEK_SET);
> if (write) {
> g_assert_cmpint(ftruncate(fd, 0), ==, 0);
> @@ -1486,6 +1487,7 @@ int main(int argc, char **argv)
> g_autofree char *temp_file = g_strdup_printf("%s/vmst.test.XXXXXX",
> g_get_tmp_dir());
> temp_fd = mkstemp(temp_file);
> + g_assert(temp_fd >= 0);
>
> module_call_init(MODULE_INIT_QOM);
>
>
