Re: [PATCH v2 1/7] block-copy: streamline choice of copy_range vs. read/write

[Vladimir Sementsov-Ogievskiy]

21.05.2021 18:10, Paolo Bonzini wrote:

Stats don't say everything.  Not having something like this:
                 s->copy_size =
                         MIN(MAX(s->cluster_size, BLOCK_COPY_MAX_COPY_RANGE),
                             QEMU_ALIGN_DOWN(block_copy_max_transfer(s->source,
                                                                     s->target),
                                             s->cluster_size));

Yes, this one always looked bad..

--
Best regards,
Vladimir