Re: [PATCH v3 1/3] qemu-config: parse configuration files to a QDict

[Paolo Bonzini]

On 21/05/21 18:09, Kevin Wolf wrote:

+    qemu_opts_absorb_qdict(opts, qdict, errp);
+    if (errp) {

This doesn't do what you wanted.

*errp would be be better, but you also need ERRP_GUARD() then.

The other option would be using the return value of
qemu_opts_absorb_qdict().

Uff, you're absolutely right.  I'm a trainwreck today...

Paolo